From 4cf8f321f03317c6156e8fe8544b4b3a9d16bb7a Mon Sep 17 00:00:00 2001 From: Dan Williams Date: Mon, 9 Apr 2007 15:08:04 -0400 Subject: [PATCH] Fix activity ID generation logic --- sugar/activity/activityfactory.py | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/sugar/activity/activityfactory.py b/sugar/activity/activityfactory.py index c795c5d9..222333e5 100644 --- a/sugar/activity/activityfactory.py +++ b/sugar/activity/activityfactory.py @@ -47,10 +47,9 @@ def create_activity_id(): if act_id == act.get_id(): found = True break - if found: - raise RuntimeError("Cannot generate unique activity id.") - - return act_id + if not found: + return act_id + raise RuntimeError("Cannot generate unique activity id.") class ActivityCreationHandler(gobject.GObject): __gsignals__ = {